fix: highlight self as variable in JavaScript (fixes #4339)#4375
Open
KJyang-0114 wants to merge 1 commit intohighlightjs:mainfrom
Open
fix: highlight self as variable in JavaScript (fixes #4339)#4375KJyang-0114 wants to merge 1 commit intohighlightjs:mainfrom
KJyang-0114 wants to merge 1 commit intohighlightjs:mainfrom
Conversation
Self should be highlighted the same as window and document. This fixes issue highlightjs#4339.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The keyword
selfwas not being highlighted as a language variable in JavaScript, unlikewindowanddocument.Solution
Added
selfto theBUILT_IN_VARIABLESarray insrc/languages/lib/ecmascript.js.Testing
npm run build)hljs.highlight('self', {language: 'javascript'}).valuenow returns<span class="hljs-variable language_">self</span>Checklist